Messages in this thread | | | Date | Fri, 21 Feb 2020 15:12:28 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/3] samples/hw_breakpoint: Drop HW_BREAKPOINT_R when reporting writes |
| |
On Fri, Feb 21, 2020 at 11:44:02AM +0000, Will Deacon wrote: > Given the name of a kernel symbol, the 'data_breakpoint' test claims to > "report any write operations on the kernel symbol". However, it creates > the breakpoint using both HW_BREAKPOINT_W and HW_BREAKPOINT_R, which > menas it also fires for read access. > > Drop HW_BREAKPOINT_R from the breakpoint attributes.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |