Messages in this thread | | | Date | Thu, 20 Feb 2020 18:21:54 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH 1/5] drm/sun4i: tcon: Introduce LVDS setup routine setting |
| |
On Wed, Feb 19, 2020 at 08:08:54PM +0200, Andrey Lebedev wrote: > From: Andrey Lebedev <andrey@lebedev.lt> > > Different sunxi flavors require slightly different sequence for enabling > LVDS output. This allows to differentiate between them. > > Signed-off-by: Andrey Lebedev <andrey@lebedev.lt> > --- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 68 ++++++++++++++++-------------- > drivers/gpu/drm/sun4i/sun4i_tcon.h | 3 ++ > 2 files changed, 39 insertions(+), 32 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c > index c81cdce6ed55..cc6b05ca2c69 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > @@ -114,46 +114,48 @@ static void sun4i_tcon_channel_set_status(struct sun4i_tcon *tcon, int channel, > } > } > > +static void sun6i_tcon_setup_lvds_phy(struct sun4i_tcon *tcon, > + const struct drm_encoder *encoder) > +{ > + u8 val; > + > + regmap_write(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG, > + SUN6I_TCON0_LVDS_ANA0_C(2) | > + SUN6I_TCON0_LVDS_ANA0_V(3) | > + SUN6I_TCON0_LVDS_ANA0_PD(2) | > + SUN6I_TCON0_LVDS_ANA0_EN_LDO); > + udelay(2); > + > + regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG, > + SUN6I_TCON0_LVDS_ANA0_EN_MB, > + SUN6I_TCON0_LVDS_ANA0_EN_MB); > + udelay(2); > + > + regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG, > + SUN6I_TCON0_LVDS_ANA0_EN_DRVC, > + SUN6I_TCON0_LVDS_ANA0_EN_DRVC); > + > + if (sun4i_tcon_get_pixel_depth(encoder) == 18) > + val = 7; > + else > + val = 0xf; > + > + regmap_write_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG, > + SUN6I_TCON0_LVDS_ANA0_EN_DRVD(0xf), > + SUN6I_TCON0_LVDS_ANA0_EN_DRVD(val)); > + > +} > +
There's an extra blank line here that was reported by checkpatch. I've fixed it up while applying.
Maxime [unhandled content-type:application/pgp-signature] | |