| Date | Thu, 20 Feb 2020 07:47:41 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v7 21/24] iomap: Restructure iomap_readpages_actor |
| |
On Wed, Feb 19, 2020 at 01:01:00PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > By putting the 'have we reached the end of the page' condition at the end > of the loop instead of the beginning, we can remove the 'submit the last > page' code from iomap_readpages(). Also check that iomap_readpage_actor() > didn't return 0, which would lead to an endless loop.
I'm obviously biassed a I wrote the original code, but I find the new very much harder to understand (not that the previous one was easy, this is tricky code..).
|