Messages in this thread | | | Date | Thu, 20 Feb 2020 12:11:28 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH net-next v3 1/9] sysfs: add sysfs_file_change_owner{_by_name}() |
| |
On Tue, Feb 18, 2020 at 05:29:35PM +0100, Christian Brauner wrote: > Add helpers to change the owner of a sysfs files. > This function will be used to correctly account for kobject ownership > changes, e.g. when moving network devices between network namespaces. > > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> > --- > /* v2 */ > - Greg Kroah-Hartman <gregkh@linuxfoundation.org>: > - Better naming for sysfs_file_change_owner() to reflect the fact that it > can be used to change the owner of the kobject itself by passing NULL as > argument. > - Christian Brauner <christian.brauner@ubuntu.com>: > - Split sysfs_file_change_owner() into two helpers sysfs_change_owner() and > sysfs_change_owner_by_name(). The former changes the owner of the kobject > itself, the latter the owner of the kobject looked up via the name > argument. > > /* v3 */ > - Greg Kroah-Hartman <gregkh@linuxfoundation.org>: > - Add explicit uid/gid parameters.
Looks much better, thanks for doing these changes. I'll review the whole series now...
greg k-h
| |