lkml.org 
[lkml]   [2020]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v3 1/9] sysfs: add sysfs_file_change_owner{_by_name}()
On Tue, Feb 18, 2020 at 05:29:35PM +0100, Christian Brauner wrote:
> Add helpers to change the owner of a sysfs files.
> This function will be used to correctly account for kobject ownership
> changes, e.g. when moving network devices between network namespaces.
>
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> /* v2 */
> - Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> - Better naming for sysfs_file_change_owner() to reflect the fact that it
> can be used to change the owner of the kobject itself by passing NULL as
> argument.
> - Christian Brauner <christian.brauner@ubuntu.com>:
> - Split sysfs_file_change_owner() into two helpers sysfs_change_owner() and
> sysfs_change_owner_by_name(). The former changes the owner of the kobject
> itself, the latter the owner of the kobject looked up via the name
> argument.
>
> /* v3 */
> - Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> - Add explicit uid/gid parameters.

Looks much better, thanks for doing these changes. I'll review the
whole series now...

greg k-h

\
 
 \ /
  Last update: 2020-02-20 12:11    [W:0.104 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site