Messages in this thread | | | Date | Thu, 20 Feb 2020 08:47:11 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver |
| |
On Wed, Feb 19, 2020 at 04:48:24PM -0800, Scott Branden wrote: > Add Broadcom VK driver offload engine. > This driver interfaces to the VK PCIe offload engine to perform > should offload functions as video transcoding on multiple streams > in parallel. VK device is booted from files loaded using > request_firmware_into_buf mechanism. After booted card status is updated > and messages can then be sent to the card. > Such messages contain scatter gather list of addresses > to pull data from the host to perform operations on.
Why is this a tty driver?
Have you worked with the V4L developers to tie this into the proper in-kernel apis for this type of functionality?
Using a tty driver seems like the totally incorrect way to do this, what am I missing?
Also, do not make up random error values, you return "-1" a lot here, that is not ok. Please fix up to return the correct -Ewhatever values instead.
thanks,
greg k-h
| |