Messages in this thread | | | Date | Wed, 19 Feb 2020 06:58:08 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH] drivers: NVME: host: core.c: Fixed some coding style issues. |
| |
On Wed, Feb 19, 2020 at 09:05:19AM +0900, Keith Busch wrote: > On Tue, Feb 18, 2020 at 11:01:31PM +0000, Edmund Merrow-Smith wrote: > > Fixed a number of style issues highlighted by scripts/checkpatch.pl. > > Mostly whitespace issues, implied int warnings, > > trailing semicolons and line length issues. > > But checkpatch.pl is on the wrong side of the 'unsigned'/'unsigned int' > debate! The C standard defined unsigned since forever ago, its usage is > not at all confusing.
Nevermind all the style issues with the patch itself. Also while I'm all for clean code - pure cleanup patches are a complete waste of time. Everyone feel free to clean up obvious warts arounds code that your are touching for a real fix or feature. But please stop sending random cleanup patches.
> > _______________________________________________ > linux-nvme mailing list > linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme ---end quoted text---
| |