Messages in this thread | | | Date | Wed, 19 Feb 2020 12:31:30 +0000 | From | Lee Jones <> | Subject | Re: [PATCH RESEND 1/2] regulator: arizona-ldo1: Improve handling of regulator unbinding |
| |
On Thu, 23 Jan 2020, Charles Keepax wrote:
> On Thu, Jan 23, 2020 at 11:48:05AM +0000, Mark Brown wrote: > > On Thu, Jan 23, 2020 at 09:26:39AM +0000, Charles Keepax wrote: > > > > > 3) We could look at doing something in regmap IRQ to change when > > > it does PM runtime calls, it is regmap doing runtime gets when > > > drivers remove IRQs that causes the issue. But my accessment was > > > that what regmap is doing makes perfect sense, so I don't think > > > this is a good approach. > > > > Why do you even care about the errors? It's not like this device is > > going to get removed in a production system and the primary IRQ will be > > disabled when the core is removed, this is just something that happens > > during development isn't it? > > I am more than happy to do the leg work if we really don't like > this solution. Do either you or Lee have any thoughts on my > selective MFD remove helpers? That seemed like the most promising > alternative solution to me.
It's hard to say without seeing your implementation, but it sounds okay in principle. Depends how messy it all ends up getting. Sounds like a scenario where a reverse -EDEFER_PROBE could be useful.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |