Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 19 Feb 2020 10:29:34 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper |
| |
On Tue, Feb 18, 2020 at 09:14:54AM -0800, Christoph Hellwig wrote: > > +static bool attach_deferred(struct device *dev) > > +{ > > + return dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO; > > +} > > This is not a very useful helper.
Depends on what one considers useful. I think such helpers make the code better readable, which is pretty useful to me.
Regards,
Joerg
| ![\](/images/icornerr.gif) |