Messages in this thread | | | Subject | Re: [PATCH] hugetlb: Remove check_coalesce_bug debug code | From | Mike Kravetz <> | Date | Wed, 19 Feb 2020 16:07:16 -0800 |
| |
On 2/19/20 3:36 PM, Mina Almasry wrote: > Commit b5f16a533ce8a ("hugetlb: support file_region coalescing > again") made changes to the resv_map code which are hard to test, it > so added debug code guarded by CONFIG_DEBUG_VM which conducts an > expensive operation that loops over the resv_map and checks it for > errors. > > Unfortunately, some distros have CONFIG_DEBUG_VM on in their default > kernels, and we don't want this debug code behind CONFIG_DEBUG_VM > and called each time a file region is added. This patch removes this > debug code. I may look into making it a test or leave it for my local > testing. > > Signed-off-by: Mina Almasry <almasrymina@google.com> > > Cc: David Rientjes <rientjes@google.com> > Cc: Mike Kravetz <mike.kravetz@oracle.com> > Cc: Shakeel Butt <shakeelb@google.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > > Fixes: b5f16a533ce8a ("hugetlb: support file_region coalescing again")
Thanks!
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
The review also applies to the original patch with the removal of this code. -- Mike Kravetz
| |