Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v6 07/19] mm: Put readahead pages in cache earlier | From | John Hubbard <> | Date | Wed, 19 Feb 2020 12:24:26 -0800 |
| |
On 2/19/20 7:01 AM, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 06:52:46AM -0800, Christoph Hellwig wrote: >> On Wed, Feb 19, 2020 at 06:41:17AM -0800, Matthew Wilcox wrote: >>> #define readahead_for_each(rac, page) \ >>> while ((page = readahead_page(rac))) >>> >>> No more readahead_next() to forget to add to filesystems which don't use >>> the readahead_for_each() iterator. Ahem.
Yes, this looks very clean. And less error-prone, which I definitely appreciate too. :)
>> >> And then kill readahead_for_each and open code the above to make it >> even more obvious? > > Makes sense. >
Great!
thanks, -- John Hubbard NVIDIA
| ![\](/images/icornerr.gif) |