| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.5 59/80] Input: ili210x - fix return value of is_visible function | Date | Tue, 18 Feb 2020 20:55:20 +0100 |
| |
From: Luca Weiss <luca@z3ntu.xyz>
commit fbd1ec000213c8b457dd4fb15b6de9ba02ec5482 upstream.
The is_visible function expects the permissions associated with an attribute of the sysfs group or 0 if an attribute is not visible.
Change the code to return the attribute permissions when the attribute should be visible which resolves the warning:
Attribute calibrate: Invalid permissions 01
Fixes: cc12ba1872c6 ("Input: ili210x - optionally show calibrate sysfs attribute") Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com> Link: https://lore.kernel.org/r/20200209145628.649409-1-luca@z3ntu.xyz Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/input/touchscreen/ili210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c @@ -321,7 +321,7 @@ static umode_t ili210x_calibrate_visible struct i2c_client *client = to_i2c_client(dev); struct ili210x *priv = i2c_get_clientdata(client); - return priv->chip->has_calibrate_reg; + return priv->chip->has_calibrate_reg ? attr->mode : 0; } static const struct attribute_group ili210x_attr_group = {
|