Messages in this thread | | | Date | Tue, 18 Feb 2020 11:04:19 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Staging: comedi: drivers: fixed errors warning coding style issue |
| |
On Sun, Feb 16, 2020 at 01:45:18PM +0530, sunnypranay wrote: > Fixed a coding style issue.
What issue is that?
> > Signed-off-by: sunnypranay <mpranay2017@gmail.com>
This doesn't seem like a Formal Name that you would use to sign legal documents.
> --- > drivers/staging/comedi/drivers.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c > index 750a6ff3c03c..76395de100a6 100644 > --- a/drivers/staging/comedi/drivers.c > +++ b/drivers/staging/comedi/drivers.c > @@ -133,7 +133,7 @@ EXPORT_SYMBOL_GPL(comedi_alloc_subdevices); > * On success, @s->readback points to the first element of the array, which > * is zero-filled. The low-level driver is responsible for updating its > * contents. @s->insn_read will be set to comedi_readback_insn_read() > - * unless it is already non-NULL. > + * Unless it is already non-NULL.
The original capitalization was correct. It should be lower case.
> * > * Returns 0 on success, -EINVAL if the subdevice has no channels, or > * -ENOMEM on allocation failure. > @@ -282,8 +282,20 @@ EXPORT_SYMBOL_GPL(comedi_readback_insn_read); > * continue waiting or some other value to stop waiting (generally 0 if the > * condition occurred, or some error value). > * > - * Returns -ETIMEDOUT if timed out, otherwise the return value from the > - * callback function. > + * Redback_insn_read() - A generic (*insn_read) for subdevice readback. ^^^^^^^^^^^^^^^^^ What is this???
regards, dan carpenter
| |