Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 18 Feb 2020 10:49:30 -0800 | Subject | Re: [PATCH] vsprintf: don't obfuscate NULL and error pointers |
| |
On Mon, Feb 17, 2020 at 4:07 PM Ilya Dryomov <idryomov@gmail.com> wrote: > > I'm not sure what you mean by efault string. Are you referring to what > %pe is doing? If so, no -- I would keep %p and %pe separate.
Right.
But bringing up %pe makes me realize that we do odd things for NULL for that. We print errors in a nice legible form, but we show NULL as a zero value, I think.
So maybe %pe should show NULL as "(null)"? Or even as just "0" to go with the error names that just look like the integer error syntax (eg "-EINVAL")
Linus
| |