Messages in this thread | | | Subject | Re: [PATCH v2 4/5] sched/pelt: Add a new runnable average signal | From | Valentin Schneider <> | Date | Tue, 18 Feb 2020 16:30:42 +0000 |
| |
On 18/02/2020 15:28, Vincent Guittot wrote: >>> @@ -532,8 +535,8 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq) >>> cfs_rq->removed.load_avg); >>> SEQ_printf(m, " .%-30s: %ld\n", "removed.util_avg", >>> cfs_rq->removed.util_avg); >>> - SEQ_printf(m, " .%-30s: %ld\n", "removed.runnable_sum", >>> - cfs_rq->removed.runnable_sum); >> >> Shouldn't that have been part of patch 3? > > No this was used to propagate load_avg >
Right, sorry about that.
>> <fugly here> >> +DECLARE_UPDATE_TG_CFS_SIGNAL(util); >> +DECLARE_UPDATE_TG_CFS_SIGNAL(runnable); > > TBH, I prefer keeping the current version which is easier to read IMO >
I did call it an eldritch horror :-) I agree with you here, it's a shame we don't really have better ways to factorize this (I don't think splitting the inputs is really an alternative).
| |