lkml.org 
[lkml]   [2020]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/7] nvmem: release the write-protect pin
From
Date


On 18/02/2020 09:42, Bartosz Golaszewski wrote:
> @@ -428,6 +429,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
> device_del(&nvmem->dev);
> err_put_device:
> put_device(&nvmem->dev);
> + gpiod_put(nvmem->wp_gpio);
> err_ida_remove:
> ida_simple_remove(&nvmem_ida, nvmem->id);
> err_free_nvmem:

This is also redundant as explained in my previous comments about release()

--srini


> --

\
 
 \ /
  Last update: 2020-02-18 13:25    [W:0.117 / U:1.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site