lkml.org 
[lkml]   [2020]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] x86: Don't declare __force_order in kaslr_64.c
    On Tue, Feb 18, 2020 at 2:45 AM Borislav Petkov <bp@alien8.de> wrote:
    >
    > On Fri, Jan 24, 2020 at 10:44:30AM -0800, H.J. Lu wrote:
    > > This updated patch fixed a typo in Subject: "care" -> "declare".
    > >
    > > From c8c26194cf5a344cd53763eaaf16c3ab609736f4 Mon Sep 17 00:00:00 2001
    > > From: "H.J. Lu" <hjl.tools@gmail.com>
    > > Date: Thu, 16 Jan 2020 12:46:51 -0800
    > > Subject: [PATCH] x86: Don't declare __force_order in kaslr_64.c
    > >
    > > GCC 10 changed the default to -fno-common, which leads to
    > >
    > > LD arch/x86/boot/compressed/vmlinux
    > > ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here
    > > make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1
    > >
    > > Since __force_order is already provided in pgtable_64.c, there is no
    > > need to declare __force_order in kaslr_64.c.
    > >
    > > Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
    > > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
    >
    > What is Yu-cheng's SOB supposed to mean here?
    >
    > The only case where it would make sense is if he's sending this patch
    > but he isn't. So what's up?
    >

    I wrote this patch as the part of the previous CET patch set Yu-cheng submitted.
    Since this is a standalone patch, he asked me to send it separately. I didn't
    remove Yu-cheng's SOB when I submitted this patch.

    --
    H.J.

    \
     
     \ /
      Last update: 2020-02-18 12:40    [W:3.738 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site