lkml.org 
[lkml]   [2020]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration
    Hi Zenghui,

    On 2020-02-18 07:25, Zenghui Yu wrote:
    > Hi Marc,

    [...]

    >> static void its_sgi_irq_domain_deactivate(struct irq_domain
    >> *domain,
    >> struct irq_data *d)
    >> {
    >> - /* Nothing to do */
    >> + struct its_vpe *vpe = irq_data_get_irq_chip_data(d);
    >> +
    >> + vpe->sgi_config[d->hwirq].enabled = false;
    >> + its_configure_sgi(d, true);
    >
    > The spec says, when C==1, VSGI clears the pending state of the vSGI,
    > leaving the configuration unchanged. So should we first clear the
    > pending state and then disable vSGI (let E==0)?

    Right you are again. We need two commands, not just one (the pseudocode
    is
    pretty explicit).

    Thanks,

    M.
    --
    Jazz is not dead. It just smells funny...

    \
     
     \ /
      Last update: 2020-02-18 10:47    [W:3.554 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site