Messages in this thread | | | Date | Tue, 18 Feb 2020 15:26:09 -0600 | From | Rob Herring <> | Subject | Re: [RFC v4 2/6] Bindings: nvmem: add bindings for JZ4780 efuse |
| |
On Mon, Feb 17, 2020 at 05:55:26PM +0100, H. Nikolaus Schaller wrote: > From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> > > This patch brings support for the JZ4780 efuse. Currently it only expose > a read only access to the entire 8K bits efuse memory. > > Tested-by: Mathieu Malaterre <malat@debian.org> > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> > Signed-off-by: Mathieu Malaterre <malat@debian.org> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > .../bindings/nvmem/ingenic,jz4780-efuse.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt
Please convert to a DT schema.
> diff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt > new file mode 100644 > index 000000000000..339e74daa9a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt > @@ -0,0 +1,17 @@ > +Ingenic JZ EFUSE driver bindings > + > +Required properties: > +- "compatible" Must be set to "ingenic,jz4780-efuse" > +- "reg" Register location and length > +- "clocks" Handle for the ahb clock for the efuse. > +- "clock-names" Must be "bus_clk"
'clk' is redundant. How about 'ahb'?
> + > +Example: > + > +efuse: efuse@134100d0 { > + compatible = "ingenic,jz4780-efuse"; > + reg = <0x134100d0 0x2c>; > + > + clocks = <&cgu JZ4780_CLK_AHB2>; > + clock-names = "bus_clk"; > +}; > -- > 2.23.0 >
| |