Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Mon, 17 Feb 2020 15:17:53 +0800 | Subject | Re: [PATCH 5/8] ASoC: sun50i-codec-analog: Enable DAPM for headphone switch |
| |
On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland <samuel@sholland.org> wrote: > > By including the headphone mute switch to the DAPM graph, both the > headphone amplifier and the Mixer/DAC inputs can be powered off when > the headphones are muted. > > The mute switch is between the source selection and the amplifier, > as per the diagram in the SoC manual. > > Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
BTW, have you also considered tying in the headphone volume control? It also has a mute setting.
ChenYu
| |