Messages in this thread | | | Subject | Re: [PATCH] ARM: imx: build v7_cpu_resume() unconditionally | From | Rouven Czerwinski <> | Date | Mon, 17 Feb 2020 08:41:37 +0100 |
| |
Hi Shawn,
On Thu, 2020-01-16 at 15:18 +0100, Rouven Czerwinski wrote: > From: Ahmad Fatoum <a.fatoum@pengutronix.de> > > This function is not only needed by the platform suspend code, but is > also > reused as the CPU resume function when the ARM cores can be powered > down > completely in deep idle, which is the case on i.MX6SX and i.MX6UL(L). > > Providing the static inline stub whenever CONFIG_SUSPEND is disabled > means > that those platforms will hang on resume from cpuidle if suspend is > disabled. > > So there are two problems: > > - The static inline stub masks the linker error > - The function is not available where needed > > Fix both by just building the function unconditionally, when > CONFIG_SOC_IMX6 is enabled. The actual code is three instructions > long, > so it's arguably ok to just leave it in for all i.MX6 kernel > configurations. > > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for > i.mx6sx") > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de> > --- > arch/arm/mach-imx/Makefile | 2 ++ > arch/arm/mach-imx/common.h | 4 ++-- > arch/arm/mach-imx/resume-imx6.S | 24 ++++++++++++++++++++++++ > arch/arm/mach-imx/suspend-imx6.S | 14 -------------- > 4 files changed, 28 insertions(+), 16 deletions(-) > create mode 100644 arch/arm/mach-imx/resume-imx6.S
Gentle ping.
Can be found on patchwork: https://patchwork.kernel.org/patch/11337147/
Thanks, Rouven Czerwinski
| |