lkml.org 
[lkml]   [2020]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 05/34] ASoC: sun8i-codec: Remove incorrect SND_SOC_DAIFMT_DSP_B
From
Date
On 2/17/20 9:02 AM, Mark Brown wrote:
> On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote:
>> DSP_A and DSP_B are not interchangeable. The timing used by the codec in
>> DSP mode is consistent with DSP_A. This is verified with an EG25-G modem
>> connected to AIF2, as well as by comparing with the BSP driver.
>>
>> Remove the DSP_B option, as it is not supported by the hardware.
>>
>> Cc: stable@kernel.org
>> Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec")
>
> This can only break things for existing systems using stable, if they
> haven't noticed a problem with DSP B they'll certainly notice failing to
> set up the DAI at all without it.

Are you suggesting that I drop this patch entirely, or only that I remove the CC
to stable (and/or Fixes: tag)? Is this something that can't be removed once it's
there, or is the concern about making user-visible changes on stable?

Thanks,
Samuel

\
 
 \ /
  Last update: 2020-02-18 02:35    [W:0.145 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site