Messages in this thread | | | Date | Fri, 14 Feb 2020 10:43:58 +0200 | From | Andrey Lebedev <> | Subject | Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20 |
| |
On Fri, Feb 14, 2020 at 08:52:18AM +0100, Maxime Ripard wrote: > > > This will create a spurious warning message for TCON1, since we > > > adjusted the driver to tell it supports LVDS, but there's no LVDS > > > reset line, so we need to make it finer grained. > > > > Yes, I can attribute two of the messages in my dmesg log [1] to this > > ("Missing LVDS properties" and "LVDS output disabled". "sun4i-tcon > > 1c0d000.lcd-controller" is indeed tcon1). And yes, I can see how they > > can be confusing to someone. > > > > I'd need some pointers on how to deal with that though (if we want to do > > it in this scope). > > Like I was mentionning, you could introduce a new compatible for each > TCON (tcon0 and tcon1) and only set the support_lvds flag for tcon0
Can you give me an idea how that compatible might look like?
tcon0: lcd-controller@1c0c000 { compatible = "allwinner,sun7i-a20-tcon", "allwinner,lvds";
or
tcon0: lcd-controller@1c0c000 { compatible = "allwinner,sun7i-a20-tcon", "allwinner,tcon0";
? Or something completely different?
-- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/
| |