Messages in this thread | | | From | Amit Kucheria <> | Date | Thu, 13 Feb 2020 20:11:19 +0530 | Subject | Re: [Patch v9 1/8] sched/pelt: Add support to track thermal pressure |
| |
On Thu, Feb 13, 2020 at 7:41 PM Thara Gopinath <thara.gopinath@linaro.org> wrote: > > On 02/13/2020 07:29 AM, Amit Kucheria wrote: > > On Wed, Jan 29, 2020 at 4:06 AM Thara Gopinath > > <thara.gopinath@linaro.org> wrote: > >>
<snip>
> >> + * Unlike rt/dl utilization tracking that track time spent by a cpu > >> + * running a rt/dl task through util_avg, the average thermal pressure is > >> + * tracked through load_avg. This is because thermal pressure signal is > >> + * weighted "delta" capacity and is not binary(util_avg is binary). "delta > > > > May I suggest a slight rewording here and in the commit description, > > > > This is because the thermal pressure signal is weighted "delta" > > capacity unlike util_avg which is binary. > > Sure! Will fix it. > > > > > It would also help, if you expanded on what you mean by binary in the > > commit description and how the delta capacity is weighted. > > I don't understand this. Binary means 0 or 1.
So the value returned by util_avg is literally 0 or 1? In which case ignore my comment. I'll read the math again later.
> delta capacity is time > weighted, i will update this.
Thanks.
| |