Messages in this thread | | | Subject | Re: [Regression 5.6-rc1][Bisected b6231ea2b3c6] Powerpc 8xx doesn't boot anymore | From | Christophe Leroy <> | Date | Thu, 13 Feb 2020 07:17:01 +0100 |
| |
Le 13/02/2020 à 04:35, Qiang Zhao a écrit : > On 02/12/2020 22:50 PM, Christophe Leroy wrote: >> -----Original Message----- >> From: Christophe Leroy <christophe.leroy@c-s.fr> >> Sent: 2020年2月12日 22:50 >> To: Rasmus Villemoes <linux@rasmusvillemoes.dk>; Leo Li >> <leoyang.li@nxp.com>; Qiang Zhao <qiang.zhao@nxp.com>; Greg >> Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Scott Wood <oss@buserror.net>; linuxppc-dev@lists.ozlabs.org; LKML >> <linux-kernel@vger.kernel.org>; linux-arm-kernel@lists.infradead.org >> Subject: Re: [Regression 5.6-rc1][Bisected b6231ea2b3c6] Powerpc 8xx doesn't >> boot anymore >> >> --- >> diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> b/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> index 4cabded8390b..341d682ec6eb 100644 >> --- a/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> +++ b/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> @@ -1351,6 +1351,7 @@ static int __init cpm_uart_console_setup(struct >> console *co, char *options) >> clrbits32(&pinfo->sccp->scc_gsmrl, SCC_GSMRL_ENR | >> SCC_GSMRL_ENT); >> } >> >> + cpm_muram_init(); >> ret = cpm_uart_allocbuf(pinfo, 1); >> >> if (ret) >> > How about the patch like below? Just a draft.
Yes, I see the idea. I think we could go for something like that. But in the powerpc 8xx case, we are talking about cpm_init(), not qe_init().
And maybe the return code should be checked, because if it's not 0, cpm_muram_init() won't have been called.
Thanks, Christophe
| |