Messages in this thread | | | Subject | Re: [PATCH 10/18] powerpc: Replace setup_irq() by request_irq() | From | Christophe Leroy <> | Date | Thu, 13 Feb 2020 11:59:35 +0100 |
| |
Le 12/02/2020 à 09:04, afzal mohammed a écrit : > request_irq() is preferred over setup_irq(). Existing callers of > setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Tested-by: Christophe Leroy <christophe.leroy@c-s.fr> # for the 8xx parts
> --- > > Since cc'ing cover letter to all maintainers/reviewers would be too > many, refer for cover letter, > https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com > > arch/powerpc/platforms/85xx/mpc85xx_cds.c | 10 +++----- > arch/powerpc/platforms/8xx/cpm1.c | 9 ++----- > arch/powerpc/platforms/8xx/m8xx_setup.c | 9 ++----- > arch/powerpc/platforms/chrp/setup.c | 14 ++++------ > arch/powerpc/platforms/powermac/pic.c | 31 ++++++++++------------- > arch/powerpc/platforms/powermac/smp.c | 9 ++----- > 6 files changed, 27 insertions(+), 55 deletions(-) >
| |