Messages in this thread | | | Subject | Re: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member | From | "Gustavo A. R. Silva" <> | Date | Thu, 13 Feb 2020 00:04:01 -0600 |
| |
On 2/12/20 19:14, Matthew Wilcox wrote: > On Wed, Feb 12, 2020 at 06:02:11PM -0600, Gustavo A. R. Silva wrote: >> Also, notice that, dynamic memory allocations won't be affected by >> this change: > > Shouldn't you also convert this: > asc_sg_head = kzalloc(sizeof(asc_scsi_q->sg_head) + > use_sg * sizeof(struct asc_sg_list), GFP_ATOMIC); > to use struct_size()? >
It's not a requirement to do that prior to applying the change proposed by this patch.
Thanks -- Gustavo
| |