Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 13 Feb 2020 09:27:52 +0100 | Subject | Re: [PATCH 3/4] spi: spidev_test: Use perror() only if errno is not 0 |
| |
On Thu, Feb 13, 2020 at 5:17 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote: > It is better to use perror() only if errno is not 0, it should use printf() > when errno is 0, otherwise there exists redudant ": Success". > > E.g. without this patch: > > $ ./spidev_test -p 1234 --input test.bin > only one of -p and --input may be selected: Success > Aborted (core dumped) > > With this patch: > > $ ./spidev_test -p 1234 --input test.bin > only one of -p and --input may be selected > Aborted (core dumped) > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |