Messages in this thread | | | Date | Wed, 12 Feb 2020 15:57:59 +0100 | From | Alexey Gladkov <> | Subject | Re: [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options |
| |
On Mon, Feb 10, 2020 at 10:30:45AM -0800, Andy Lutomirski wrote: > On Mon, Feb 10, 2020 at 7:06 AM Alexey Gladkov <gladkov.alexey@gmail.com> wrote: > > > > This is a cleaning patch to add helpers to set and get proc mount > > options instead of directly using them. This make it easy to track > > what's happening and easy to update in future. > > On a cursory inspection, this looks like it obfuscates the code, and I > don't see where it does something useful later in the series. What is > this abstraction for?
To be honest, this part is from Djalal Harouni. For me, these wrappers exist for a slight increase in readability.
I will not cry if you tell me to remove them :)
-- Rgrds, legion
| |