Messages in this thread | | | Date | Wed, 12 Feb 2020 13:16:03 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH RFC 5/7] perf pmu: Support matching by sysid |
| |
On Wed, Feb 12, 2020 at 10:08:44AM +0000, John Garry wrote:
SNIP
> > > > > > I wish to see some test for all this.. I can only think about having > > > 'test' json files compiled with perf and 'perf test' that looks them > > > up and checks that all is in the proper place > > > > OK, let me consider this part for perf test support. > > I will note that perf test has many issues on my arm64 board: > > do] password for john: > 1: vmlinux symtab matches kallsyms : Skip > 2: Detect openat syscall event : FAILED! > 3: Detect openat syscall event on all cpus : FAILED! > 4: Read samples using the mmap interface : FAILED! > 5: Test data source output : Ok > 6: Parse event definition strings : FAILED! > 7: Simple expression parser : Ok > 8: PERF_RECORD_* events & perf_sample fields : Ok > 9: Parse perf pmu format : Ok > 10: DSO data read : Ok > 11: DSO data cache : Ok > 12: DSO data reopen : Ok > 13: Roundtrip evsel->name : Ok > 14: Parse sched tracepoints fields : FAILED! > 15: syscalls:sys_enter_openat event fields : FAILED!
looks like some issue with tracepoints
> 16: Setup struct perf_event_attr : Skip > 17: Match and link multiple hists : Ok > 18: 'import perf' in python : Ok > 21: Breakpoint accounting : Ok > 22: Watchpoint : > 22.1: Read Only Watchpoint : Ok > 22.2: Write Only Watchpoint : Ok > 22.3: Read / Write Watchpoint : Ok > 22.4: Modify Watchpoint : Ok > 23: Number of exit events of a simple workload : Ok > 24: Software clock events period values : Ok > 25: Object code reading : Ok > 26: Sample parsing : Ok > 27: Use a dummy software event to keep tracking : Ok > 28: Parse with no sample_id_all bit set : Ok > 29: Filter hist entries : Ok > 30: Lookup mmap thread : Ok > 31: Share thread maps : Ok > 32: Sort output of hist entries : Ok > 33: Cumulate child hist entries : Ok > 34: Track with sched_switch : Ok > 35: Filter fds with revents mask in a fdarray : Ok > 36: Add fd to a fdarray, making it autogrow : Ok > 37: kmod_path__parse : Ok > 38: Thread map : Ok > 39: LLVM search and compile : > 39.1: Basic BPF llvm compile : Skip > 39.2: kbuild searching : Skip > 39.3: Compile source for BPF prologue generation : Skip > 39.4: Compile source for BPF relocation : Skip
Skip is fine ;-)
> 40: Session topology : FAILED!
I'd expect that one to fail if we don't have special code to support arm in there
> 41: BPF filter : > 41.1: Basic BPF filtering : Skip > 41.2: BPF pinning : Skip > 41.3: BPF prologue generation : Skip > 41.4: BPF relocation checker : Skip > 42: Synthesize thread map : Ok > 43: Remove thread map : Ok > 44: Synthesize cpu map : Ok > 45: Synthesize stat config : Ok > 46: Synthesize stat : Ok > 47: Synthesize stat round : Ok > 48: Synthesize attr update : Ok > 49: Event times : Ok > 50: Read backward ring buffer : FAILED!
hum, I thought this was generic code that would work across archs
> 51: Print cpu map : Ok > 52: Merge cpu map : Ok > 53: Probe SDT events : Ok > 54: is_printable_array : Ok > 55: Print bitmap : Ok > 56: perf hooks umber__scnprintf : Ok > 59: mem2node : Ok > 60: time utils : Ok > 61: Test jit_write_elf : Ok > 62: maps__merge_in : Ok > 63: DWARF unwind : Ok > 64: Check open filename arg using perf trace + vfs_getname: FAILED! > 65: Add vfs_getname probe to get syscall args filenames : FAILED! > 66: Use vfs_getname probe to get syscall args filenames : FAILED!
with these we have always a problem across archs, it's tricky to make script test that works everywhere :-\
> 67: Zstd perf.data compression/decompression : Ok > 68: probe libc's inet_pton & backtrace it with ping : Skip > john@ubuntu:~/linux$ > > I know that the perf tool definitely has issues for system topology for > arm64, which I need to check on. > > Maybe I can conscribe help internally to help check the rest...
the json/alias test would be also to make sure the x86 still works, so regardless of some tests failing on arm, I think it's still better to have that test
thanks, jirka
| |