Messages in this thread | | | Subject | Re: [PATCH v4 2/3] selftests: KVM: AMD Nested test infrastructure | From | Paolo Bonzini <> | Date | Wed, 12 Feb 2020 12:38:52 +0100 |
| |
On 06/02/20 23:57, Krish Sadhukhan wrote: >> >> + >> +void nested_svm_check_supported(void) >> +{ >> + struct kvm_cpuid_entry2 *entry = >> + kvm_get_supported_cpuid_entry(0x80000001); >> + >> + if (!(entry->ecx & CPUID_SVM)) { >> + fprintf(stderr, "nested SVM not enabled, skipping test\n"); > I think a better message would be: > > "nested SVM not supported on this CPU, skipping test\n" > > Also, the function should ideally return a boolean and let the callers > print whatever they want.
It would be "not supported by KVM", which is equivalent to "not enabled" for all purposes.
Thanks,
Paolo
| |