Messages in this thread | | | From | Nicolas Boichat <> | Date | Wed, 12 Feb 2020 16:57:30 +0800 | Subject | Re: [PATCH] PM / OPP: Add support for multiple regulators |
| |
On Wed, Feb 12, 2020 at 4:13 PM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 12-02-20, 15:55, Nicolas Boichat wrote: > > The OPP table can contain multiple voltages and regulators, and > > implementing that logic does not add a lot of code or complexity, > > so let's modify _generic_set_opp_regulator to support that use > > case. > > > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > > This is already supported in a different way. See how following driver > does this (hint dev_pm_opp_register_set_opp_helper()). > > drivers/opp/ti-opp-supply.c > > The problem with a generic solution is that we can't assume an order > for programming of the regulators, as this can be complex on few > platforms.
I see... And you're right that it's probably best to change the voltages in a specific order (I just ignored that problem ,-P). I do wonder if there's something we could do in the core/DT to specify that order (if it's a simple order?), it's not really ideal to have to copy paste code around...
> -- > viresh
| |