Messages in this thread | | | Date | Wed, 12 Feb 2020 19:38:29 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH] bpf_prog_offload_info_fill: replace bitwise AND by logical AND |
| |
On Wed, 12 Feb 2020 20:32:27 +0100, Johannes Krude wrote: > This if guards whether user-space wants a copy of the offload-jited > bytecode and whether this bytecode exists. By erroneously doing a bitwise > AND instead of a logical AND on user- and kernel-space buffer-size can lead > to no data being copied to user-space especially when user-space size is a > power of two and bigger then the kernel-space buffer. > > Signed-off-by: Johannes Krude <johannes@krude.de>
Thank you for the fix, in the future please provide a Fixes tag and include the tree name in the PATCH tag, e.g. [PATCH bpf], or [PATCH net] etc.
Fixes: fcfb126defda ("bpf: add new jited info fields in bpf_dev_offload and bpf_prog_info")
Acked-by: Jakub Kicinski <kuba@kernel.org>
| |