Messages in this thread | | | Date | Wed, 12 Feb 2020 10:31:33 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v1] printk: Declare log_wait as external variable |
| |
On (20/02/11 13:43), Petr Mladek wrote: > > Even better solution might be to move fs/proc/kmsg.c to > kernel/printk/proc_kmsg.c and declare printk_log_wait only > in kernel/printk/internal.h. I think that this is what > Sergey suggested.
Yes, right.
> Another great thing would be to extract devkmsg stuff from > kernel/printk/printk.c and put it into kernel/printk/dev_kmsg.c.
Yeah, can do, I would still prefer proc_kmsg to "move in". Either both can live in printk.c (won't make it much worse), or in kernel/printk/dev_kmsg.c and kernel/printk/proc_kmsg.c
I can take a look at dev_ksmg.c/proc_kmsg.c option, unless someone else wants to spend their time on this.
-ss
| |