Messages in this thread | | | Date | Mon, 10 Feb 2020 13:07:15 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH RFC 4/7] perf pmu: Rename uncore symbols to include system PMUs |
| |
On Fri, Jan 24, 2020 at 10:35:02PM +0800, John Garry wrote:
SNIP
> /* Only split the uncore group which members use alias */ > - if (!evsel->use_uncore_alias) > + if (!evsel->use_uncore_or_system_alias) > goto out; > > /* The events must be from the same uncore block */ > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 8b99fd312aae..569aba4cec89 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -623,7 +623,7 @@ static struct perf_cpu_map *pmu_cpumask(const char *name) > return NULL; > } > > -static bool pmu_is_uncore(const char *name) > +static bool pmu_is_uncore_or_sys(const char *name)
so we detect uncore PMU by checking for cpumask file
I don't see the connection here with the sysid or '_sys' checking, that's just telling which ID to use when looking for an alias, no? shouldn't that be separated?
jirka
| |