Messages in this thread | | | Date | Mon, 10 Feb 2020 15:29:42 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 01/12] mm: fix a comment in sys_swapon |
| |
On Tue, 14 Jan 2020 17:12:14 +0100 Christoph Hellwig <hch@lst.de> wrote:
> claim_swapfile now always takes i_rwsem. > > ... > > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3157,7 +3157,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) > mapping = swap_file->f_mapping; > inode = mapping->host; > > - /* If S_ISREG(inode->i_mode) will do inode_lock(inode); */ > + /* will take i_rwsem; */ > error = claim_swapfile(p, inode); > if (unlikely(error)) > goto bad_swap;
http://lkml.kernel.org/r/20200206090132.154869-1-naohiro.aota@wdc.com removes this comment altogether. Please check that this is OK?
| |