lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/12] mm: fix a comment in sys_swapon
    On Tue, 14 Jan 2020 17:12:14 +0100 Christoph Hellwig <hch@lst.de> wrote:

    > claim_swapfile now always takes i_rwsem.
    >
    > ...
    >
    > --- a/mm/swapfile.c
    > +++ b/mm/swapfile.c
    > @@ -3157,7 +3157,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
    > mapping = swap_file->f_mapping;
    > inode = mapping->host;
    >
    > - /* If S_ISREG(inode->i_mode) will do inode_lock(inode); */
    > + /* will take i_rwsem; */
    > error = claim_swapfile(p, inode);
    > if (unlikely(error))
    > goto bad_swap;

    http://lkml.kernel.org/r/20200206090132.154869-1-naohiro.aota@wdc.com
    removes this comment altogether. Please check that this is OK?

    \
     
     \ /
      Last update: 2020-02-11 00:30    [W:3.039 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site