Messages in this thread | | | Date | Sat, 1 Feb 2020 16:28:45 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 3/4] tracing: Remove useless code in dynevent_arg_pair_add() |
| |
On Fri, 31 Jan 2020 15:55:33 -0600 Tom Zanussi <zanussi@kernel.org> wrote:
> The final addition to q is unnecessary, since q isn't ever used > afterwards. >
Yeah, thanks for updating :)
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
> Signed-off-by: Tom Zanussi <zanussi@kernel.org> > --- > kernel/trace/trace_dynevent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c > index f9cfcdc9d1f3..204275ec8d71 100644 > --- a/kernel/trace/trace_dynevent.c > +++ b/kernel/trace/trace_dynevent.c > @@ -322,7 +322,7 @@ int dynevent_arg_pair_add(struct dynevent_cmd *cmd, > pr_err("field string is too long: %s\n", arg_pair->rhs); > return -E2BIG; > } > - cmd->remaining -= delta; q += delta; > + cmd->remaining -= delta; > > return ret; > } > -- > 2.14.1 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |