Messages in this thread | | | Date | Mon, 7 Dec 2020 12:59:53 +0100 | From | Peter Zijlstra <> | Subject | Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code |
| |
On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote:
> void tick_handover_do_timer(void) > { > + if (tick_do_timer_cpu == smp_processor_id()) > + tick_do_timer_cpu = cpumask_first(cpu_online_mask);
For the paranoid amongst us, would it make sense to add something like:
/* * There must always be at least one online CPU. */ WARN_ON_ONCE(tick_do_timer_cpu >= nr_cpu_ids);
> }
| |