lkml.org 
[lkml]   [2020]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Hello,

Johan Jonker <jbx6244@gmail.com> wrote on Sun, 6 Dec 2020 15:10:57
+0100:

> Hi Yifeng,
>
> Meanwhile, could you post a RFC version for Uboot based on this version
> plus comments, so people can test the whole process from programming,
> booting and kernel?
>
> On 11/30/20 1:49 PM, Johan Jonker wrote:
> > Hi,
> >
> > Looks good to me.
> > Do the maintainers or someone else have any major issues?
> > Could Miquel indicate if a version 16 must be send for that 'ret'
> > variable alone or is it OK now?
> >
> >
> > On 11/30/20 11:00 AM, Yifeng Zhao wrote:
> >> This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308,
> >> RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using
> >> 8-bit NAND interface on the ARM based RK3308 platform.
>
> [..]
>
> >> +/**
> >> + * struct rk_ecc_cnt_status: represent a ecc status data.
>
> represent the ECC status data.

The driver looks good to me now, can you please send a v16 with the
last comments from Johan (thanks for reviewing so carefully btw!).

Thanks,
Miquèl

\
 
 \ /
  Last update: 2020-12-07 10:59    [W:0.019 / U:4.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site