Messages in this thread | | | From | Alexander Duyck <> | Date | Sun, 6 Dec 2020 09:32:23 -0800 | Subject | Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM |
| |
On Sat, Dec 5, 2020 at 3:49 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Fri, 4 Dec 2020 14:38:03 -0800 Alexander Duyck wrote: > > > > The patches look good to me. Just need to address the minor issue that > > > > seems to have been present prior to the introduction of this patch > > > > set. > > > > > > > > Reviewed-by: Alexander Duyck <alexanderduyck@fb.com> > > > > > > Thanks for your review. Just some operational questions - since this previously > > > existed do you want me to re-spin the series to a v4 for this, or should it be > > > a follow up after the series? > > > > > > If I respin it, would you prefer that change to occur at the start or end > > > of the series? > > > > I don't need a respin, but if you are going to fix it you should > > probably put out the patch as something like a 8/7. If you respin it > > should happen near the start of the series as it is a bug you are > > addressing. > > Don't we need that patch to be before this series so it can be > back ported easily? Or is it not really a bug?
You're right. For backports it would make it easier to have the patch be before the changes. As far as being a bug, it is one, but it isn't an urgent bug as it is basically some bad exception handling so the likelihood of seeing it should be quite low.
| |