Messages in this thread | | | Subject | Re: [PATCH] kasan: fix slab double free when cpu-hotplug | From | Kuan-Ying Lee <> | Date | Fri, 4 Dec 2020 20:01:35 +0800 |
| |
On Fri, 2020-12-04 at 18:22 +0800, qiang.zhang@windriver.com wrote: > From: Zqiang <qiang.zhang@windriver.com> > > When a CPU offline, the per-cpu quarantine's offline be set true, > after this, if the quarantine_put be called in this CPU, the objects > will be free and return false, free objects doesn't to be done, due > to return false, the slab memory manager will free this objects. > > Fixes: 41ab1aae781f ("kasan: fix object remaining in offline per-cpu quarantine") > Signed-off-by: Zqiang <qiang.zhang@windriver.com> > --- > mm/kasan/quarantine.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > index d98b516f372f..55783125a767 100644 > --- a/mm/kasan/quarantine.c > +++ b/mm/kasan/quarantine.c > @@ -194,7 +194,6 @@ bool quarantine_put(struct kmem_cache *cache, void *object) > > q = this_cpu_ptr(&cpu_quarantine); > if (q->offline) { > - qlink_free(&meta->quarantine_link, cache); > local_irq_restore(flags); > return false; > }
Hi Qiang,
Thanks for fixing this. Due to that issue, my commit has been removed by Stephen from linux-next.
Hi Stephen, Andrew,
Should I directly upload the v4 or Stephen can pick the commit which has been removed back to the linux-next.
What do you think?
Thanks a lot.
Kuan-Ying
| |