lkml.org 
[lkml]   [2020]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mlx4: style: replace zero-length array with flexible-array member.
From
Date


On 12/30/2020 8:28 AM, YANG LI wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use "flexible array members"[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.9/process/
> deprecated.html#zero-length-and-one-element-arrays
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci <abaci@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> index e8ed2319..4029a8b 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> @@ -314,7 +314,7 @@ struct mlx4_en_tx_ring {
>
> struct mlx4_en_rx_desc {
> /* actual number of entries depends on rx ring stride */
> - struct mlx4_wqe_data_seg data[0];
> + struct mlx4_wqe_data_seg data[];
> };
>
> struct mlx4_en_rx_ring {
>

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Thanks.

\
 
 \ /
  Last update: 2020-12-30 10:40    [W:0.036 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site