lkml.org 
[lkml]   [2020]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mm/page_alloc: remove the static for local variable node_order
On Wed, Dec 30, 2020 at 8:45 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > local variable node_order do not need the static here.
>
> It bloody well does. It can be up to 2^10 entries on x86 (and larger
> on others) That's 4kB which you've now moved onto the stack.

This is not the first time I have seen similar changes. So what
do you think about adding a comment here to avoid another one
do this in the feature?

>
> Please, learn more about what you're doing. I suggest sending patches
> to drivers/staging; that will help you learn how to submit patches to
> linux.

\
 
 \ /
  Last update: 2020-12-30 14:43    [W:0.087 / U:22.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site