lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 02/19] vdpa_sim: remove unnecessary headers inclusion
    From
    Date
    On 12/3/20 9:04 AM, Stefano Garzarella wrote:
    > Some headers are not necessary, so let's remove them to do
    > some cleaning.
    >
    > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

    Hi,
    What makes you say that some of these are unnecessary?

    Please use Rule #1 from Documentation/process/submit-checklist.rst:

    1) If you use a facility then #include the file that defines/declares
    that facility. Don't depend on other header files pulling in ones
    that you use.


    so just because it will compile without these headers being explictly
    #included does not mean that you should remove them.


    > ---
    > v3:
    > - avoided to remove some headers with structures and functions directly
    > used (device.h, slab.h, virtio_byteorder.h)[Jason]
    > ---
    > drivers/vdpa/vdpa_sim/vdpa_sim.c | 10 ----------
    > 1 file changed, 10 deletions(-)
    >
    > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
    > index 6a90fdb9cbfc..b08f28d20d8d 100644
    > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
    > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
    > @@ -7,20 +7,10 @@
    > *
    > */
    >
    > -#include <linux/init.h>

    above is used by __init and __exit.

    > #include <linux/module.h>
    > #include <linux/device.h>
    > -#include <linux/kernel.h>
    > -#include <linux/fs.h>
    > -#include <linux/poll.h>

    Looks OK to remove poll.h.

    > #include <linux/slab.h>
    > -#include <linux/sched.h>

    Might be OK for sched.h.

    > -#include <linux/wait.h>

    Might be OK for wait.h.

    > -#include <linux/uuid.h>
    > -#include <linux/iommu.h>
    > #include <linux/dma-map-ops.h>
    > -#include <linux/sysfs.h>
    > -#include <linux/file.h>
    > #include <linux/etherdevice.h>
    > #include <linux/vringh.h>
    > #include <linux/vdpa.h>
    >

    I didn't check the others.


    --
    ~Randy

    \
     
     \ /
      Last update: 2020-12-03 18:39    [W:6.852 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site