Messages in this thread | | | Date | Thu, 3 Dec 2020 17:54:20 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/3] x86/uprobes: Fix not using prefixes.nbytes for loop over prefixes.bytes |
| |
On Thu, Dec 03, 2020 at 10:45:48AM -0600, Tom Lendacky wrote: > Since this is based on the array size, can > > idx < NUM_LEGACY_PREFIXES > > be replaced with: > > idx < ARRAY_SIZE(insn->prefixes.bytes)
Actually, this needs another change:
struct insn_field { union { insn_value_t value; insn_byte_t bytes[NUM_LEGACY_PREFIXES];
because you can have max. 4 legacy prefixes and then we can do either of the checks above.
Mine is shorter tho. :-)
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |