lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 352/717] ARM: dts: meson: fix PHY deassert timing requirements
    Date
    From: Stefan Agner <stefan@agner.ch>

    [ Upstream commit 656ab1bdcd2b755dc161a9774201100d5bf74b8d ]

    According to the datasheet (Rev. 1.9) the RTL8211F requires at least
    72ms "for internal circuits settling time" before accessing the PHY
    registers. On similar boards with the same PHY this fixes an issue where
    Ethernet link would not come up when using ip link set down/up.

    Fixes: a2c6e82e5341 ("ARM: dts: meson: switch to the generic Ethernet PHY reset bindings")
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> # on Odroid-C1+
    Signed-off-by: Stefan Agner <stefan@agner.ch>
    Signed-off-by: Kevin Hilman <khilman@baylibre.com>
    Link: https://lore.kernel.org/r/ff78772b306411e145769c46d4090554344db41e.1607363522.git.stefan@agner.ch
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/meson8b-odroidc1.dts | 2 +-
    arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
    index 0c26467de4d03..5963566dbcc9d 100644
    --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
    +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
    @@ -224,7 +224,7 @@
    reg = <0>;

    reset-assert-us = <10000>;
    - reset-deassert-us = <30000>;
    + reset-deassert-us = <80000>;
    reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;

    interrupt-parent = <&gpio_intc>;
    diff --git a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
    index cc498191ddd1d..8f4eb1ed45816 100644
    --- a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
    +++ b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
    @@ -81,7 +81,7 @@
    reg = <0>;

    reset-assert-us = <10000>;
    - reset-deassert-us = <30000>;
    + reset-deassert-us = <80000>;
    reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
    };
    };
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:19    [W:2.096 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site