lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 338/717] Bluetooth: btusb: Add the missed release_firmware() in btusb_mtk_setup_firmware()
    Date
    From: Jing Xiangfeng <jingxiangfeng@huawei.com>

    [ Upstream commit d1e9d232e1e60fa63df1b836ec3ecba5abd3fa9d ]

    btusb_mtk_setup_firmware() misses to call release_firmware() in an error
    path. Jump to err_release_fw to fix it.

    Fixes: f645125711c8 ("Bluetooth: btusb: fix up firmware download sequence")
    Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bluetooth/btusb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
    index 1005b6e8ff743..a9981678199d7 100644
    --- a/drivers/bluetooth/btusb.c
    +++ b/drivers/bluetooth/btusb.c
    @@ -3067,7 +3067,7 @@ static int btusb_mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
    err = btusb_mtk_hci_wmt_sync(hdev, &wmt_params);
    if (err < 0) {
    bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
    - return err;
    + goto err_release_fw;
    }

    fw_ptr = fw->data;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:17    [W:2.181 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site