lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 315/717] phy: mediatek: allow compile-testing the hdmi phy
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit f5f6e01f9164040ba120f30522efdb4deceb529a ]

    Compile-testing the DRM_MEDIATEK_HDMI driver shows two missing
    dependencies, one results in a link failure:

    arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_probe':
    phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name'
    arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined reference to `devm_clk_register'
    arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined reference to `of_clk_add_provider'
    arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined reference to `of_clk_src_simple_get'

    The other one is a harmless warning:

    WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
    Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
    Selected by [y]:
    - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]

    Fix these by adding dependencies on CONFIG_OF and CONFIG_COMMON_CLK.
    With that done, there is also no reason against adding
    CONFIG_COMPILE_TEST.

    Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20201204135650.2744481-1-arnd@kernel.org
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/mediatek/Kconfig | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
    index c8126bde9d7cc..43150608d8b62 100644
    --- a/drivers/phy/mediatek/Kconfig
    +++ b/drivers/phy/mediatek/Kconfig
    @@ -38,7 +38,9 @@ config PHY_MTK_XSPHY

    config PHY_MTK_HDMI
    tristate "MediaTek HDMI-PHY Driver"
    - depends on ARCH_MEDIATEK && OF
    + depends on ARCH_MEDIATEK || COMPILE_TEST
    + depends on COMMON_CLK
    + depends on OF
    select GENERIC_PHY
    help
    Support HDMI PHY for Mediatek SoCs.
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:16    [W:2.281 / U:1.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site