lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 318/717] memory: jz4780_nemc: Fix potential NULL dereference in jz4780_nemc_probe()
    Date
    From: Zhang Changzhong <zhangchangzhong@huawei.com>

    [ Upstream commit 4bfa07300b9334b487ed4f3d4901c35ebb31b7ca ]

    platform_get_resource() may fail and return NULL, so we should
    better check it's return value to avoid a NULL pointer dereference
    a bit later in the code.

    This is detected by Coccinelle semantic patch.

    Fixes: 911a88829725 ("memory: jz4780-nemc: driver for the NEMC on JZ4780 SoCs")
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    Acked-by: Paul Cercueil <paul@crapouillou.net>
    Link: https://lore.kernel.org/r/1607070717-32880-1-git-send-email-zhangchangzhong@huawei.com
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/jz4780-nemc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c
    index 3ec5cb0fce1ee..465ea92990d7e 100644
    --- a/drivers/memory/jz4780-nemc.c
    +++ b/drivers/memory/jz4780-nemc.c
    @@ -291,6 +291,8 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
    nemc->dev = dev;

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!res)
    + return -EINVAL;

    /*
    * The driver currently only uses the registers up to offset
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:15    [W:2.770 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site