lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 101/453] spi: img-spfi: fix reference leak in img_spfi_resume
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit ee5558a9084584015c8754ffd029ce14a5827fa8 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in img_spfi_resume, so we should fix it.

    Fixes: deba25800a12b ("spi: Add driver for IMG SPFI controller")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201102145651.3875-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-img-spfi.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c
    index f4a8f470aecc2..e9ef80983b791 100644
    --- a/drivers/spi/spi-img-spfi.c
    +++ b/drivers/spi/spi-img-spfi.c
    @@ -771,8 +771,10 @@ static int img_spfi_resume(struct device *dev)
    int ret;

    ret = pm_runtime_get_sync(dev);
    - if (ret)
    + if (ret) {
    + pm_runtime_put_noidle(dev);
    return ret;
    + }
    spfi_reset(spfi);
    pm_runtime_put(dev);

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:09    [W:2.565 / U:1.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site