lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 415/453] spi: atmel-quadspi: Disable clock in probe error path
    Date
    From: Lukas Wunner <lukas@wunner.de>

    commit 0e685017c7ba1a2fe9f6f1e7a9302890747d934c upstream.

    If the call to of_device_get_match_data() fails on probe of the Atmel
    QuadSPI driver, the clock "aq->pclk" is erroneously not unprepared and
    disabled. Fix it.

    Fixes: 2e5c88887358 ("spi: atmel-quadspi: add support for sam9x60 qspi controller")
    Signed-off-by: Lukas Wunner <lukas@wunner.de>
    Cc: <stable@vger.kernel.org> # v5.1+
    Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
    Cc: Boris Brezillon <boris.brezillon@collabora.com>
    Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
    Link: https://lore.kernel.org/r/8f8dc2815aa97b2378528f08f923bf81e19611f0.1604874488.git.lukas@wunner.de
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/atmel-quadspi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/spi/atmel-quadspi.c
    +++ b/drivers/spi/atmel-quadspi.c
    @@ -510,7 +510,7 @@ static int atmel_qspi_probe(struct platf
    if (!aq->caps) {
    dev_err(&pdev->dev, "Could not retrieve QSPI caps\n");
    err = -EINVAL;
    - goto exit;
    + goto disable_pclk;
    }

    if (aq->caps->has_qspick) {

    \
     
     \ /
      Last update: 2020-12-28 15:09    [W:4.118 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site